Skip to content

Analytics Hub: Add Main View Model #8185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 23, 2022
Merged

Analytics Hub: Add Main View Model #8185

merged 5 commits into from
Nov 23, 2022

Conversation

@Ecarrion
Copy link
Contributor

@Ecarrion Ecarrion commented Nov 22, 2022

part of #8148

Why

This PR adds an AnalyticsHubViewModel filled with dummy data in order to add a base so we can begin expanding it further.

How

  • Adds an AnalyticsReportCardViewModel type so we can transmit data easily to AnalyticsReportCardView
  • Adds AnalyticsHubViewModel with revenue and orders dummy data.
  • Upates AnalyticsHubView to read data from its view model.

Screenshot

screenshot

Testing

  • Launch the app
  • Tap the "See More" button from the main dashboard
  • See the report cards with dummy data.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@Ecarrion Ecarrion added the category: tracks Related to analytics, including Tracks Events. label Nov 22, 2022
@Ecarrion Ecarrion added this to the 11.4 milestone Nov 22, 2022
@peril-woocommerce
Copy link

peril-woocommerce bot commented Nov 22, 2022

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@rachelmcr rachelmcr self-assigned this Nov 23, 2022
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 23, 2022

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8185-956253d on your iPhone

If you need access to App Center, please ask a maintainer to add you.

rachelmcr
rachelmcr approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@rachelmcr rachelmcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for getting us started with this. 🚀

@Ecarrion Ecarrion linked an issue Nov 23, 2022 that may be closed by this pull request
[Analytics Hub] Create reusable Analytics stats main body with info card component #8148
Closed
Base automatically changed from issue/8148-cards to trunk November 23, 2022 13:23
@Ecarrion Ecarrion merged commit 02384e2 into trunk Nov 23, 2022
@Ecarrion Ecarrion deleted the issue/8148-view-model branch November 23, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ealeksandrov ealeksandrov Awaiting requested review from ealeksandrov

@ThomazFB ThomazFB Awaiting requested review from ThomazFB

1 more reviewer

@rachelmcr rachelmcr rachelmcr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rachelmcr rachelmcr

Labels

category: tracks Related to analytics, including Tracks Events.

Projects

None yet

Milestone

11.4

Development

Successfully merging this pull request may close these issues.

[Analytics Hub] Create reusable Analytics stats main body with info card component

4 participants

@Ecarrion @wpmobilebot @rachelmcr